Add initial support for java references for yaml #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdebruin
changed the title
Laurens-W
approved these changes
Nov 21, 2024
rewrite-java-test/src/test/java/org/openrewrite/java/ChangeTypeTest.java
Outdated
Show resolved
Hide resolved
rewrite-java/src/main/java/org/openrewrite/java/TypeMatcher.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/YamlReference.java
Outdated
Show resolved
Hide resolved
|
I'd applied some light polish to the parallel PR in 713ced2 ; would be good to apply those same changes here as well, and resolve the conflicts. |
# Conflicts: # rewrite-java-test/src/test/java/org/openrewrite/java/ChangeTypeTest.java # rewrite-java/src/main/java/org/openrewrite/java/TypeMatcher.java
|
Yes, would be good to update this PR now that the dust has settled a bit regarding the rename refactoring. |
# Conflicts: # rewrite-java/src/main/java/org/openrewrite/java/PackageMatcher.java # rewrite-java/src/main/java/org/openrewrite/java/TypeMatcher.java
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/package-info.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/package-info.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/package-info.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/YamlReference.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/YamlReference.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/YamlReference.java
Outdated
Show resolved
Hide resolved
rewrite-yaml/src/main/java/org/openrewrite/yaml/trait/YamlReference.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Great to see this added! Any last concerns before we merge @knutwannheden ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This adds initial support for generating references to java type from a Yaml fine in a similar fashion, and with similar limitations, as in:
What's your motivation?
Adding this feature allows existing recipes that support references to be applied to .properties files. For more details see:
Referenceto include.propertiesand.yml#4681Anything in particular you'd like reviewers to focus on?
The focus points are almost on to one with the previously referenced implementation of references to Java type in
.propertiesfiles.Anyone you would like to review specifically?
@timtebeek @Laurens-W
Any additional context
Checklist