Add RegEx support to ChangeTageValue recipe #4732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthochristen
force-pushed
the
xml-change-value-add-regex
branch
from
fe52084 to
2ab4744
Compare
added 2 commits
November 29, 2024 00:58
Plus some refactoring
anthochristen
force-pushed
the
xml-change-value-add-regex
branch
from
2ab4744 to
2da58d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Allows ChangeTagValue to take in regex in
oldValueparameter.What's your motivation?
Anything in particular you'd like reviewers to focus on?
First of, if there's no popular / recommended alternatives and if not then if this makes sense. Then I'll make it ready for review.
Please leave your thoughts here or on the issue #4731.
Anyone you would like to review specifically?
@timtebeek? - Because I see you actively replying ;)
@gadams00 - Because, history.
Have you considered any alternatives or workarounds?
Not really. I found this to be more appealing.
Checklist