Parser failures with unnecessary semicolons #5063
Merged
+251
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…micolons-in-new-class
greg-at-moderne
changed the title
|
I still get a diff when parsing diff --git a/A.java b/A.java
index 2868c61..c0b28d5 100644
--- a/A.java
+++ b/A.java
@@ -1 +1 @@
-class A {;;;int i = 0;}
\ No newline at end of file
+class A {;int i = 0;}
\ No newline at end of file |
jevanlingen
approved these changes
Feb 21, 2025
greg-at-moderne
deleted the
parse-failure-with-semicolons-in-new-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR hijacked by @greg-at-moderne.
What
Fixing a few issues with unnecessary semicolons in Java classes - either in between statements or at the end of class body.
What's your motivation?
Addressing feedback from one of the OpenRewrite users.