Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python3.6 #26

Merged
merged 8 commits into from
May 2, 2024
Merged

Feature/python3.6 #26

merged 8 commits into from
May 2, 2024

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Apr 28, 2024

Reference Issues/PRs

#2
python 3.6 support added
enhance test cases' stability by adding a Retry mechanism to retry in case of HTTP Readtimeout errors or similar issues

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese self-assigned this Apr 28, 2024
@AHReccese AHReccese added enhancement New feature or request new feature labels Apr 28, 2024
@AHReccese AHReccese added this to the Reserver v0.2 milestone Apr 28, 2024
@AHReccese AHReccese linked an issue Apr 28, 2024 that may be closed by this pull request
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Thanks for your efforts 💯
Please take a look at my comment 🥇

dev-requirements.txt Outdated Show resolved Hide resolved
@AHReccese AHReccese requested a review from sepandhaghighi May 1, 2024 10:24
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sepandhaghighi sepandhaghighi merged commit 68d08ab into dev May 2, 2024
42 checks passed
@sepandhaghighi sepandhaghighi deleted the feature/python3.6 branch May 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.6
2 participants