216 provide templates when creating new entries unique carer language #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f29347b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 18.12% 17.85% -0.27%
==========================================
Files 118 119 +1
Lines 3129 3204 +75
Branches 113 115 +2
==========================================
+ Hits 567 572 +5
- Misses 2508 2577 +69
- Partials 54 55 +1 ☔ View full report in Codecov by Sentry. |
openscript
requested changes
Jan 6, 2025
There was a problem hiding this comment.
I like the selection via the dropdown button. It feels like a very natural way of applying a template. Good job!
The following doesn't seem to work yet:
- After changing or creating a new entry, the templates are not available on subsequent creations without reloading the page. Probably this is a caching problem.
Screencast.From.2025-01-06.13-47-28.mp4
- Maybe we should enable word wrapping for the template selection items as they become quite long and can be cut of:
- Maybe a gap between the input or making it a group with the input field would further improve the user interface.
apps/backend/src/research/participants/participants.controller.ts
Outdated
Show resolved
Hide resolved
…-when-creating-new-entries-unique-carer-language
stampaaaron
deleted the
216-provide-templates-when-creating-new-entries-unique-carer-language
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.