[WLM Auto tagging] Add compressed trie structure to store Rules #16971
Conversation
kaushalmahi12
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for cc729f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1e4030d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 24420b4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1024603: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1b283fc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
kaushalmahi12
force-pushed
the
wlm/rule-matching
branch
from
1b283fc to
6f9acee
Compare
|
❌ Gradle check result for 6f9acee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
force-pushed
the
wlm/rule-matching
branch
from
6f9acee to
dda7c79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16971 +/- ##
============================================
- Coverage 72.36% 72.35% -0.01%
- Complexity 65733 65811 +78
============================================
Files 5318 5323 +5
Lines 305674 305835 +161
Branches 44349 44366 +17
============================================
+ Hits 221197 221296 +99
- Misses 66341 66463 +122
+ Partials 18136 18076 -60 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
force-pushed
the
wlm/rule-matching
branch
from
dda7c79 to
7350245
Compare
|
❕ Gradle check result for 7350245: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@jainankitk @reta can you review this PR ? |
@kaushalmahi12 - Most of the logic in this PR is Trie data structure. I am wondering if we have something similar in Opensearch already or we can get it from some library |
+1 to what @jainankitk said , could we use |
|
Thanks @reta! |
|
I will close this PR as the suggested data structure is a suitable and well tested alternate. |
Description
This change introduces the compressed trie structure which will store and perform matching for Rules. This is one of the foundational change in order to do the Rule based automatic tagging.
Related Issues
#16888
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.