Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WLM] Fix the QueryGroupTask logging bug #17169

Closed
wants to merge 2 commits into from
Closed

[WLM] Fix the QueryGroupTask logging bug #17169

wants to merge 2 commits into from
+75 −0

Conversation

kaushalmahi12
Copy link
Contributor

@kaushalmahi12 kaushalmahi12 commented Jan 28, 2025 •
edited
Loading

This change is taken from the PR: #16981 which fixes the #16874 bug.

@kaushalmahi12
[WLM] Add wlm support for scroll API (opensearch-project#16981)
8251a83 
* add wlm support for scroll API

Signed-off-by: Kaushal Kumar <[email protected]>

* add CHANGELOG entry

Signed-off-by: Kaushal Kumar <[email protected]>

* remove untagged tasks from WLM tracking

Signed-off-by: Kaushal Kumar <[email protected]>

* add UTs for invalid tasks

Signed-off-by: Kaushal Kumar <[email protected]>

* fix UT failures

Signed-off-by: Kaushal Kumar <[email protected]>

* rename a field in QueryGroupTask

Signed-off-by: Kaushal Kumar <[email protected]>

---------

Signed-off-by: Kaushal Kumar <[email protected]>
@jainankitk
Copy link
Collaborator

@kaushalmahi12 - We can probably skip the change for scroll API in 2.x, as even without that, the bug should get fixed?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 8251a83: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (1c7f719) to head (8251a83).

Files with missing lines Patch % Lines
...rch/action/search/TransportSearchScrollAction.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17169      +/-   ##
============================================
+ Coverage     71.89%   71.91%   +0.01%     
- Complexity    65852    65889      +37     
============================================
  Files          5332     5332              
  Lines        306587   306594       +7     
  Branches      44720    44721       +1     
============================================
+ Hits         220429   220482      +53     
+ Misses        67754    67734      -20     
+ Partials      18404    18378      -26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jainankitk
jainankitk reviewed Jan 28, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kaushalmahi12 kaushalmahi12 changed the title [backport 2.x][WLM] Add wlm support for scroll API (#16981) [WLM] Fix the QueryGroupTask logging bug Jan 28, 2025
@kaushalmahi12 kaushalmahi12 force-pushed the backport-2.x/scroll-api-fix branch from ec3dec0 to d7be772 Compare January 29, 2025 00:10
@kaushalmahi12 kaushalmahi12 force-pushed the backport-2.x/scroll-api-fix branch from d7be772 to 11bd8bd Compare January 29, 2025 00:17
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 11bd8bd: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

@kaushalmahi12 - We can probably skip the change for scroll API in 2.x, as even without that, the bug should get fixed?

@jainankitk @kaushalmahi12 FYI constructors can be exempt from the compatibility check as most API classes are not meant to be constructed by downstream components. See #14575

@jainankitk
Copy link
Collaborator

Thanks @andrross for sharing. Good to know about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainankitk jainankitk jainankitk left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalmahi12 @jainankitk @andrross