[WLM] Fix the QueryGroupTask logging bug #17171
Merged
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add wlm support for scroll API Signed-off-by: Kaushal Kumar <[email protected]> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <[email protected]> * remove untagged tasks from WLM tracking Signed-off-by: Kaushal Kumar <[email protected]> * add UTs for invalid tasks Signed-off-by: Kaushal Kumar <[email protected]> * fix UT failures Signed-off-by: Kaushal Kumar <[email protected]> * rename a field in QueryGroupTask Signed-off-by: Kaushal Kumar <[email protected]> --------- Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
jainankitk
approved these changes
Jan 29, 2025
kaushalmahi12
force-pushed
the
wlm/log-bugfix
branch
from
11bd8bd to
b83ff50
Compare
Signed-off-by: Kaushal Kumar <[email protected]>
kaushalmahi12
force-pushed
the
wlm/log-bugfix
branch
from
b83ff50 to
5e3e991
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #17171 +/- ##
============================================
+ Coverage 71.89% 71.97% +0.07%
- Complexity 65852 65874 +22
============================================
Files 5332 5332
Lines 306587 306591 +4
Branches 44720 44721 +1
============================================
+ Hits 220429 220670 +241
+ Misses 67754 67478 -276
- Partials 18404 18443 +39 ☔ View full report in Codecov by Sentry. |
jainankitk
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is taken from the PR: #16981 which fixes the #16874 bug.