Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Update the dependencies in .babelrc #294

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Dec 12, 2023

Description

Deprecated dependencies:

  • @babel/plugin-proposal-class-properties
  • @babel/plugin-proposal-object-rest-spread

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 force-pushed the cypress-12-bump branch 2 times, most recently from 3a06af6 to e2b8d1a Compare December 13, 2023 01:45
@RyanL1997 RyanL1997 changed the title [CI/CD] Bump Cypress version to 12 [Bug fix] Manually add @babel/plugin-proposal-class-properties Dec 13, 2023
@RyanL1997 RyanL1997 changed the title [Bug fix] Manually add @babel/plugin-proposal-class-properties [Bug fix] Manually add missing dependencies for babel Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2d3de0) 94.73% compared to head (c0fbda0) 94.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997 RyanL1997 changed the title [Bug fix] Manually add missing dependencies for babel [Bug fix] Update the dependencies in .babelrc Dec 13, 2023
@RyanL1997 RyanL1997 marked this pull request as ready for review December 13, 2023 03:50
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are a ⭐

@mengweieric mengweieric merged commit 51e3191 into opensearch-project:main Dec 13, 2023
9 checks passed
@ps48
Copy link
Member

ps48 commented Dec 13, 2023

@RyanL1997 Thanks for the PR. But can we backport this to 2.x? @derek-ho @Swiddis Can we please make sure next time the reviews we do contain appropriate backport labels before approving. Missing backports have been an issue for a long time and messes up the repo branch chaining.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 13, 2023
Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 51e3191)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit 51e3191)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CI failure caused by not found @babel/plugin-proposal-class-properties
5 participants