1050: Reduce build warnings.

[vAdyar]

Description

• Changed the indentation from spaces to tab.
• Included private no-args constructors.
• refactoring.

Related Issues

Resolves #1050

Check List

• New functionality includes testing.
• New functionality has been documented.
• [ ] API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (9671912) to head (df24676).

Files with missing lines	Patch %	Lines
.../opensearch/flowframework/util/ApiSpecFetcher.java	66.66%	1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1051      +/-   ##
============================================
+ Coverage     75.53%   75.57%   +0.04%     
  Complexity     1050     1050              
============================================
  Files           101      101              
  Lines          5215     5208       -7     
  Branches        498      498              
============================================
- Hits           3939     3936       -3     
+ Misses         1038     1034       -4     
  Partials        238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbwiddis]

Hey @vAdyar thanks for contributing! The addition of the private constructors and change of private variable look great.

Changed the indentation from spaces to tab.

The intent is not to change the formatting, but just to change the name of the parameter used to control it, specifically this line:

flow-framework/formatter/formatting.gradle

Line 38 in 9671912

indentWithSpaces()

We don't want tabs. That line converts all tabs to spaces (good) but the name of the parameter has changed.

Some hints:

• after making any changes, run the command line ./gradlew spotlessApply to format your code.
• you need to use DCO to signoff each commit. Most editors have a little check box you can select to add the SIgned-off-by line. Or you can use the -s switch if committing from the command line. You can sign off the immediate previous commits with git commit -s --amend assuming you've set up your name and email in git. See https://github.com/opensearch-project/flow-framework/blob/main/CONTRIBUTING.md#developer-certificate-of-origin