Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new maintainers #1235

Merged

Conversation

vikasvb90
Copy link
Collaborator

Description

Adding @tandonks @shiv0408 @soosinha to maintainers list.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: vikasvb90 <[email protected]>
@vikasvb90
Copy link
Collaborator Author

@bowenlan-amzn @Hailong-am @RamakrishnaChilaka
Please provide your approval on this PR. (Also, please leave it open after approval)

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Dec 12, 2024

Pending GitHub Request: opensearch-project/.github#248

@peterzhuamazon peterzhuamazon merged commit a32b669 into opensearch-project:main Jan 2, 2025
9 of 10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1235-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a32b66975bf90be8090eb614a38d19880730e0b7
# Push it to GitHub
git push --set-upstream origin backport/backport-1235-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1235-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants