-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating cypress version and fixing CVE-2024-21538 #1247
Conversation
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
6ea6917
to
dc0fbc8
Compare
The cypress test github workflow needs to be reconfigured to execute the tests after bumping the cypress version so will investigate that separately. For now, will merge this bump to unblock 2.19 release. |
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
- Coverage 61.61% 60.92% -0.70%
==========================================
Files 345 348 +3
Lines 12449 12842 +393
Branches 2509 2589 +80
==========================================
+ Hits 7671 7824 +153
- Misses 4075 4279 +204
- Partials 703 739 +36 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kshitij Tandon <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1247-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3eb1b24382f63abf362eb61147a174500b3085ed
# Push it to GitHub
git push --set-upstream origin backport/backport-1247-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x Then, create a pull request where the |
…t#1247) * Updating cypress version Signed-off-by: Kshitij Tandon <[email protected]> * Fixing CVE-2024-21538 Signed-off-by: Kshitij Tandon <[email protected]> * Testing cypress baselining Signed-off-by: Kshitij Tandon <[email protected]> * Modifying spec patterns Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue in snpashot e2e test Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 3eb1b24)
…t#1247) * Updating cypress version Signed-off-by: Kshitij Tandon <[email protected]> * Fixing CVE-2024-21538 Signed-off-by: Kshitij Tandon <[email protected]> * Testing cypress baselining Signed-off-by: Kshitij Tandon <[email protected]> * Modifying spec patterns Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue in snpashot e2e test Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 3eb1b24)
) (#1249) * Updating cypress version and fixing CVE-2024-21538 (#1247) * Updating cypress version Signed-off-by: Kshitij Tandon <[email protected]> * Fixing CVE-2024-21538 Signed-off-by: Kshitij Tandon <[email protected]> * Testing cypress baselining Signed-off-by: Kshitij Tandon <[email protected]> * Modifying spec patterns Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue in snpashot e2e test Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 3eb1b24) * Updating upload artifacts to v4 Signed-off-by: Kshitij Tandon <[email protected]> * Updating certificates and key Signed-off-by: Kshitij Tandon <[email protected]> * Updating cypress.config Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>
…1247) (#1252) * Updating cypress version and fixing CVE-2024-21538 (#1247) * Updating cypress version Signed-off-by: Kshitij Tandon <[email protected]> * Fixing CVE-2024-21538 Signed-off-by: Kshitij Tandon <[email protected]> * Testing cypress baselining Signed-off-by: Kshitij Tandon <[email protected]> * Modifying spec patterns Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue in snpashot e2e test Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 3eb1b24) * Updating upload artifacts to v4 Signed-off-by: Kshitij Tandon <[email protected]> * Updating certificates in cypress.config Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>
Description
Issues Resolved
Resolves #1246
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.