Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot management UI #195

Merged
merged 27 commits into from
Jun 24, 2022
Merged

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented May 17, 2022

Description

[Describe what this change achieves]

Issues Resolved

opensearch-project/index-management#280

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review June 21, 2022 16:51
@bowenlan-amzn bowenlan-amzn requested a review from a team June 21, 2022 16:51
@bowenlan-amzn bowenlan-amzn changed the title SM dev - setup basic structure Snapshot management UI Jun 21, 2022
<EuiSpacer />

<ContentPanel title="Snapshot schedule" titleSize="m">
<CronSchedule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note. This element seems to be converting a preset time option to a cron expression as expected, but doesn't convert the other way around.

For example, 30 4 * * * should be Daily at 4:30 AM. However, if you select the Daily at 2:00 AM preset option, change the Schedule frequency to Custom (Cron expression), paste 30 4 * * *, and then change the Schedule frequency type back to Daily, the 2:00 AM option will still be selected. I wouldn't think this is a blocker, but just wanted to call that out in case you intend to support that conversion direction.

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Copy link
Contributor

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When editing an existing policy, only the Policy name and Description fields seem to pull the existing definitions for editing; the rest of the form has the default values.

Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
@bowenlan-amzn bowenlan-amzn merged commit 699828e into opensearch-project:sm-dev Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants