-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot management UI #195
Conversation
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
Outdated
Show resolved
Hide resolved
public/pages/SnapshotPolicies/containers/SnapshotPolicies/SnapshotPolicies.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
Outdated
Show resolved
Hide resolved
.../pages/CreateSnapshotPolicy/components/SnapshotIndicesRepoInput/SnapshotIndicesRepoInput.tsx
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
Outdated
Show resolved
Hide resolved
<EuiSpacer /> | ||
|
||
<ContentPanel title="Snapshot schedule" titleSize="m"> | ||
<CronSchedule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note. This element seems to be converting a preset time option to a cron expression as expected, but doesn't convert the other way around.
For example, 30 4 * * *
should be Daily
at 4:30 AM
. However, if you select the Daily
at 2:00 AM
preset option, change the Schedule frequency
to Custom (Cron expression)
, paste 30 4 * * *
, and then change the Schedule frequency
type back to Daily
, the 2:00 AM
option will still be selected. I wouldn't think this is a blocker, but just wanted to call that out in case you intend to support that conversion direction.
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/containers/CreateSnapshotPolicy/CreateSnapshotPolicy.tsx
Show resolved
Hide resolved
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When editing an existing policy, only the Policy name
and Description
fields seem to pull the existing definitions for editing; the rest of the form has the default values.
Signed-off-by: bowenlan-amzn <[email protected]>
public/pages/SnapshotPolicies/containers/SnapshotPolicies/SnapshotPolicies.tsx
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
Show resolved
Hide resolved
public/pages/CreateSnapshotPolicy/components/CronSchedule/CronSchedule.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Description
[Describe what this change achieves]
Issues Resolved
opensearch-project/index-management#280
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.