Merge snapshot management into main branch #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
===========================================
- Coverage 61.85% 51.78% -10.08%
===========================================
Files 158 182 +24
Lines 4632 5757 +1125
Branches 775 924 +149
===========================================
+ Hits 2865 2981 +116
- Misses 1546 2555 +1009
Partials 221 221
Continue to review full report at Codecov.
|
Signed-off-by: bowenlan-amzn <[email protected]>
downsrob
reviewed
Jun 24, 2022
| let cronParts = { hour, minute, dayOfWeek, dayOfMonth, frequencyType }; | ||
| cronParts = { ...cronParts, ...input }; | ||
| const expression = buildCronExpression(cronParts, cronExpression); | ||
| // console.log(`sm dev built expression ${expression}`); |
There was a problem hiding this comment.
I see a lot of commented out lines of old code in this file
There was a problem hiding this comment.
Some of the comments like this are kept deliberately
praveensameneni
approved these changes
Jun 24, 2022
AWSHurneyt
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bowenlan-amzn [email protected]
Description
[Describe what this change achieves]
Issues Resolved
opensearch-project/index-management#280
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.