-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SM dev - SM datamodel and CRUD skeleton #355
SM dev - SM datamodel and CRUD skeleton #355
Conversation
7ac450f
to
69c5466
Compare
@@ -208,6 +219,7 @@ class IndexManagementPlugin : JobSchedulerExtension, NetworkPlugin, ActionPlugin | |||
@Suppress("ComplexMethod") | |||
override fun getJobParser(): ScheduledJobParser { | |||
return ScheduledJobParser { xcp, id, jobDocVersion -> | |||
log.info("Plugin job parser") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to leave a todo to remove the unnecessary logging like this so we don't forget later? Maybe we could use some standard format like
// TODO SLM <todo>
for things like this so we can easily search later and we don't miss any of the pre-release todos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we use log.info("sm dev: .....")
for all the logs that probably need to be removed.
And for all the TODO we add in the project, we use // TODO SM
...main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/engine/statemachine/SMState.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/SMMetadata.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/SMMetadata.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/SMPolicy.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/util/IndexUtils.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/SMPolicy.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/SMPolicy.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/opensearchapi/OpenSearchExtensions.kt
Outdated
Show resolved
Hide resolved
...in/org/opensearch/indexmanagement/snapshotmanagement/api/transport/delete/DeleteSMRequest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/api/transport/SMActions.kt
Outdated
Show resolved
Hide resolved
4ce461a
to
513ae4c
Compare
* Strengthen scroll search in Coordinator Normally user won't have >10k ISM jobs, so we don't want to use scroll search every time. Signed-off-by: bowenlan-amzn <[email protected]>
* Removes rc1 qualifier Signed-off-by: Clay Downs <[email protected]> * Allows error in shrink test Signed-off-by: Clay Downs <[email protected]>
* Adds documentation issue workflow Signed-off-by: Clay Downs <[email protected]> * Makes the issue template more relevant Signed-off-by: Clay Downs <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
513ae4c
to
af5ead8
Compare
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
…ction without use of it. Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
This commit #345 on main branch are left out, because DCO problem. But when we merge sm-dev to main, this should be covered. |
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sm-dev #355 +/- ##
============================================
- Coverage 75.25% 71.84% -3.42%
- Complexity 2144 2151 +7
============================================
Files 262 277 +15
Lines 12444 13032 +588
Branches 1966 2026 +60
============================================
- Hits 9365 9363 -2
- Misses 2012 2594 +582
- Partials 1067 1075 +8
Continue to review full report at Codecov.
|
Signed-off-by: bowenlan-amzn [email protected]
Issue #, if available:
#280
Description of changes:
Data model
snapshot management policy
snapshot management metadata
APIs
Pour in draft for several APIs, not the finalized version, just the basic structure.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.