-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JS compile issues caused by OpenSearch JPMS Refactoring #730
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,6 @@ | |
package org.opensearch.jobscheduler.sampleextension; | ||
|
||
import org.opensearch.action.index.IndexRequest; | ||
import org.opensearch.client.Client; | ||
import org.opensearch.common.xcontent.XContentType; | ||
import org.opensearch.jobscheduler.spi.JobExecutionContext; | ||
import org.opensearch.jobscheduler.spi.ScheduledJobParameter; | ||
|
@@ -22,6 +21,7 @@ | |
import org.opensearch.cluster.service.ClusterService; | ||
import org.opensearch.plugins.Plugin; | ||
import org.opensearch.threadpool.ThreadPool; | ||
import org.opensearch.transport.client.Client; | ||
|
||
import java.util.List; | ||
import java.util.UUID; | ||
|
@@ -32,7 +32,7 @@ | |
* The job runner should be a singleton class if it uses OpenSearch client or other objects passed | ||
* from OpenSearch. Because when registering the job runner to JobScheduler plugin, OpenSearch has | ||
* not invoke plugins' createComponents() method. That is saying the plugin is not completely initalized, | ||
* and the OpenSearch {@link org.opensearch.client.Client}, {@link ClusterService} and other objects | ||
* and the OpenSearch {@link Client}, {@link ClusterService} and other objects | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this |
||
* are not available to plugin and this job runner. | ||
* | ||
* So we have to move this job runner intialization to {@link Plugin} createComponents() method, and using | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggesting this @cwperks. The security test pass now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this part was missing all the time 😄