Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky tests #1370

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

ryanbogan
Copy link
Member

Description

Fixes the flaky tests on k-NN

Backport of #1355

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan ryanbogan force-pushed the backport/backport-1355-to-2.x branch from 95ec396 to 97411c5 Compare January 3, 2024 18:59
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46d001d) 85.13% compared to head (97411c5) 85.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1370      +/-   ##
============================================
- Coverage     85.13%   85.09%   -0.04%     
  Complexity     1229     1229              
============================================
  Files           157      157              
  Lines          5046     5046              
  Branches        479      479              
============================================
- Hits           4296     4294       -2     
- Misses          544      546       +2     
  Partials        206      206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanbogan ryanbogan merged commit f519fe2 into 2.x Jan 3, 2024
76 checks passed
@github-actions github-actions bot deleted the backport/backport-1355-to-2.x branch January 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants