Refactor TrainingJobRouteDecisionInfo test to use KNNTestCase #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we have seen that TrainingJobRouteDecisionInfoTransportActionTests has been having failures on Windows. The failures are related to an unintialized cluster state. This does not have anything to do with the test itself. Most likely, it is the result of state dependence that happens with KNNSingleNodeTestCase. This change refactors the class to use mocks and a lighter weight base class, KNNTestCase. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
============================================
- Coverage 85.10% 85.07% -0.04%
Complexity 1254 1254
============================================
Files 163 163
Lines 5104 5104
Branches 477 477
============================================
- Hits 4344 4342 -2
- Misses 554 556 +2
Partials 206 206 ☔ View full report in Codecov by Sentry. |
|
Waiting for k-NN build to be completed. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
Recently, we have seen that TrainingJobRouteDecisionInfoTransportActionTests has been having failures on Windows. The failures are related to an unintialized cluster state. This does not have anything to do with the test itself. Most likely, it is the result of state dependence that happens with KNNSingleNodeTestCase. This change refactors the class to use mocks and a lighter weight base class, KNNTestCase. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit 5c24d99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, we have seen that TrainingJobRouteDecisionInfoTransportActionTests has been having failures on Windows (for example: https://github.com/jmazanec15/k-NN-1/actions/runs/7415192445/job/20177850505). The failures are related to an unintialized cluster state tryiing to be accessed after calling training. Still not sure why the cluster state is null after the test starts, but this does not have anything to do with the test itself.
Most likely, the flakiness is the result of state sharing that happens with KNNSingleNodeTestCase. KNNSingleNodeTestCase inherits from OpenSearchSingleNodeTestCase which will start a node as a part of running each test. OpenSearchSingleNodeTestCase is unnecessary for this test case where we just want to validate that a transport action can read the correct job count on the node. This change refactors the class to use mocks and a lighter weight base class, KNNTestCase. In general, we should always prefer KNNTestCase over KNNSingleNodeTestCase.
Issues Resolved
#1368
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.