Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate nmslib engine #2427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate nmslib engine #2427

wants to merge 1 commit into from

Conversation

kotwanikunal
Copy link
Member

@kotwanikunal kotwanikunal commented Jan 23, 2025 •
edited
Loading

Description

  • Deprecates nmslib engine support

Related Issues

  • N/A

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kotwanikunal
Deprecate nmslib engine
1122ce1 
Signed-off-by: Kunal Kotwani <[email protected]>
@kotwanikunal kotwanikunal mentioned this pull request Jan 23, 2025
Open
1 task
@kotwanikunal kotwanikunal marked this pull request as ready for review January 23, 2025 18:32
@navneet1v navneet1v self-requested a review January 23, 2025 18:34
ryanbogan
ryanbogan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ryanbogan ryanbogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

martin-gaievski
martin-gaievski approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, nmslib was a long-time favorite, and its time has passed

@kotwanikunal kotwanikunal mentioned this pull request Jan 23, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@ryanbogan ryanbogan ryanbogan approved these changes

@navneet1v navneet1v navneet1v approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

@shatejas shatejas Awaiting requested review from shatejas shatejas is a code owner

@0ctopus13prime 0ctopus13prime Awaiting requested review from 0ctopus13prime 0ctopus13prime is a code owner

Assignees
No one assigned
Labels
backport 2.x v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kotwanikunal @navneet1v @ryanbogan @martin-gaievski