Enabled concurrent graph creation for Lucene engine with index thread qty settings #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
added
Enhancements
navneet1v
changed the title
navneet1v
commented
Jan 31, 2025
src/main/java/org/opensearch/knn/index/codec/KNN9120Codec/KNN9120PerFieldKnnVectorsFormat.java
Outdated
Show resolved
Hide resolved
navneet1v
added
indexing-improvements
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
src/main/java/org/opensearch/knn/index/codec/KNN9120Codec/KNN9120PerFieldKnnVectorsFormat.java
Outdated
Show resolved
Hide resolved
kotwanikunal
approved these changes
Jan 31, 2025
Vikasht34
previously approved these changes
Feb 1, 2025
navneet1v
force-pushed
the
2.x
branch
2 times, most recently
from
dc3dbd0 to
68fb964
Compare
… qty settings Signed-off-by: Navneet Verma <[email protected]>
naveentatikonda
approved these changes
Feb 2, 2025
shatejas
approved these changes
Feb 2, 2025
|
Merging the change in 2.x branch since 2.19 is cut off. and I will work with release owner to see if we can put this change in 2.19 |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-2480-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d22f1aeee7a44f5e88c9693b84ffd81a7cc312ae
# Push it to GitHub
git push --set-upstream origin backport/backport-2480-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-mainThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
… qty settings (#2480) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit d22f1ae)
navneet1v
added a commit
that referenced
this pull request
Feb 3, 2025
… qty settings (#2480) (#2488) Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit d22f1ae) Co-authored-by: Navneet Verma <[email protected]>
|
The changes for this feature is merged and based on the nighly run I can see the performance of the Force merge has improved. Nightly runs uses index_thread_qty as 2. and now with this change we can see the force merge time has reduced by 50%. 10M 768D dataset
1M 768D Dataset
|
navneet1v
added a commit
to navneet1v/k-NN
that referenced
this pull request
Feb 4, 2025
… qty settings (opensearch-project#2480) Signed-off-by: Navneet Verma <[email protected]>
5 tasks
navneet1v
added a commit
to navneet1v/k-NN
that referenced
this pull request
Feb 6, 2025
… qty settings (opensearch-project#2480) Signed-off-by: Navneet Verma <[email protected]>
navneet1v
added a commit
that referenced
this pull request
Feb 6, 2025
… qty settings (#2480) (#2493) Signed-off-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled concurrent graph creation for Lucene engine with index thread qty settings
Related Issues
Resolves #1581
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.