[Remote Vector Index Build] Introduce RemoteIndexBuilder skeleton #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
14 tasks
jed326
force-pushed
the
remote-vector-dev
branch
from
25981af to
8040bae
Compare
navneet1v
reviewed
Feb 13, 2025
...main/java/org/opensearch/knn/index/codec/KNN10010Codec/KNN10010PerFieldKnnVectorsFormat.java
Outdated
Show resolved
Hide resolved
navneet1v
reviewed
Feb 13, 2025
...in/java/org/opensearch/knn/index/codec/KNN10010Codec/NativeEngines10010KnnVectorsWriter.java
Outdated
Show resolved
Hide resolved
jed326
force-pushed
the
remote-vector-dev
branch
from
8040bae to
3f39eba
Compare
…ate interface Signed-off-by: Jay Deng <[email protected]>
jed326
force-pushed
the
remote-vector-dev
branch
from
3f39eba to
739d2ef
Compare
|
Thanks @navneet1v , I also agree that a new writer isn't completely necessary as the underlying formats are not changing. Moreover, the remote build should be format agnostic anyways, so I've refactored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First PR for #2465
In order to review changes incrementally, this PR is scoped down to only the following:
This PR is already fairly large with the introduction of all the
10010classes, so keeping the vector upload changes in a separate follow-up PR now as that will deserve it's own in-depth discussion.Related Issues
Relates: #2465
Check List
- [ ] New functionality has been documented.- [ ] API changes companion pull request created.--signoff.- [ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.