Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Disjuction query in HybridQueryPhaseSearcher #1127

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Jan 21, 2025

Description

Validate Disjuction query in HybridQueryPhaseSearcher to avoid having hybrid as a nested query

{
    "query": {
        "dis_max": {
            "queries": [
                {
                    "match": {
                        "title": "Shakespeare poems"
                    }
                },
                {
                    "hybrid": {
                        "queries": [
                            {
                                "match": {
                                    "passage_text": {
                                        "query": "Hi world"
                                    }
                                }
                            }
                        ]
                    }
                }
            ]
        }
    }
}

Response

{
    "error": {
        "root_cause": [
            {
                "type": "illegal_argument_exception",
                "reason": "hybrid query must be a top level query and cannot be wrapped into other queries"
            }
        ],

Related Issues

Part of #1125

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a unit tests for this case?

Signed-off-by: Owais <[email protected]>
@owaiskazi19
Copy link
Member Author

can you please add a unit tests for this case?

Added test. @martin-gaievski can you review again?

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you

Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-gaievski martin-gaievski merged commit 9799c6c into opensearch-project:main Jan 24, 2025
39 of 41 checks passed
@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch v2.19.0 labels Jan 24, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2025
* Validate Disjuction query in HybridQueryPhaseSearcher

Signed-off-by: Owais <[email protected]>
(cherry picked from commit 9799c6c)
vibrantvarun pushed a commit that referenced this pull request Jan 24, 2025
* Validate Disjuction query in HybridQueryPhaseSearcher

Signed-off-by: Owais <[email protected]>
(cherry picked from commit 9799c6c)

Co-authored-by: Owais Kazi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants