-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Disjuction query in HybridQueryPhaseSearcher #1127
Validate Disjuction query in HybridQueryPhaseSearcher #1127
Conversation
aadb1ff
to
61bc2e3
Compare
Signed-off-by: Owais <[email protected]>
61bc2e3
to
9c41276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a unit tests for this case?
src/main/java/org/opensearch/neuralsearch/search/query/HybridQueryPhaseSearcher.java
Show resolved
Hide resolved
Signed-off-by: Owais <[email protected]>
Added test. @martin-gaievski can you review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9799c6c
into
opensearch-project:main
* Validate Disjuction query in HybridQueryPhaseSearcher Signed-off-by: Owais <[email protected]> (cherry picked from commit 9799c6c)
* Validate Disjuction query in HybridQueryPhaseSearcher Signed-off-by: Owais <[email protected]> (cherry picked from commit 9799c6c) Co-authored-by: Owais Kazi <[email protected]>
Description
Validate Disjuction query in HybridQueryPhaseSearcher to avoid having hybrid as a nested query
Response
Related Issues
Part of #1125
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.