Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced upload api with register of ml commons #1130

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

owaiskazi19
Copy link
Member

Description

Replaced upload api of ml commons with the new url (_register)

Related Issues

Resolves ##1114

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vibrantvarun
Copy link
Member

@peterzhuamazon Can you help us with this new github CI check * Check workflow events * . It is blocking the merge of this PR.

@peterzhuamazon
Copy link
Member

@peterzhuamazon Can you help us with this new github CI check * Check workflow events * . It is blocking the merge of this PR.

Hi, please merge this and rebase, sorry for confusion:

Thanks.

@vibrantvarun
Copy link
Member

Also part of #1095

@vibrantvarun vibrantvarun merged commit a4ca7b4 into opensearch-project:main Jan 22, 2025
40 checks passed
@vibrantvarun vibrantvarun added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jan 22, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1130-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a4ca7b46e9b7969e54210e99a96d6888aea65185
# Push it to GitHub
git push --set-upstream origin backport/backport-1130-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1130-to-2.x.

@owaiskazi19
Copy link
Member Author

On 2.x the change is already present here

@martin-gaievski martin-gaievski removed the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants