Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if file path is invalid. #793

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

dblock
Copy link
Member

@dblock dblock commented Jan 14, 2025

Description

Warn if file path is invalid. We want to make sure the path follows the convention of the API being tested.

PASSED  plugins/ml/ml/train_and_predict.yaml (tests/plugins/ml/ml/train_and_predict.yaml)
WARNING Invalid path detected, please move /tests/plugins/ml/ml/train_and_predict.yaml to ml/train_predict.yaml.

Complied with the convention for tests/default, gave up for the rest, too many to change.

Issues Resolved

Closes #792
Closes #795

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Changes Analysis

Commit SHA: 67b3170
Comparing To SHA: d3bdef9

API Changes

Summary

└─┬Paths
  ├──[➖] path (4690:3)❌ 
  └──[➕] path (4690:3)

Document Element Total Changes Breaking Changes
paths 2 1
  • BREAKING Changes: 1 out of 2
  • Removals: 1
  • Additions: 1
  • Breaking Removals: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12869427212/artifacts/2456541989

API Coverage

Before After Δ
Covered (%) 663 (64.94 %) 662 (64.84 %) -1 (-0.1 %)
Uncovered (%) 358 (35.06 %) 359 (35.16 %) 1 (0.1 %)
Unknown 44 45 1

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Spec Test Coverage Analysis

Total Tested
594 593 (99.83 %)

@dblock dblock force-pushed the warn-if-invalid-path branch 2 times, most recently from 8ac3d1e to ab120cc Compare January 16, 2025 22:35
@dblock dblock marked this pull request as ready for review January 16, 2025 22:39
@dblock dblock force-pushed the warn-if-invalid-path branch from ab120cc to 93bc5fc Compare January 16, 2025 22:43
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
@Xtansia Xtansia merged commit d8e4583 into opensearch-project:main Jan 20, 2025
32 checks passed
@dblock dblock deleted the warn-if-invalid-path branch January 20, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants