Add time field to getStats schema in _common.yml #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hye-on <[email protected]>
hye-on
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Signed-off-by: hye-on <[email protected]>
|
|
Changes AnalysisCommit SHA: 5fe4310 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12878758087/artifacts/2465137796 API Coverage
|
Spec Test Coverage Analysis
|
Signed-off-by: hye-on <[email protected]>
Xtansia
requested changes
Jan 22, 2025
| @@ -1714,6 +1714,9 @@ components: | |||
| format: int64 | |||
| getTime: | |||
| $ref: '#/components/schemas/Duration' | |||
| deprecated: true | |||
There was a problem hiding this comment.
This should have x-version-deprecated: '2.19' as well
| @@ -1714,6 +1714,9 @@ components: | |||
| format: int64 | |||
| getTime: | |||
| $ref: '#/components/schemas/Duration' | |||
| deprecated: true | |||
| time: | |||
| $ref: '#/components/schemas/Duration' | |||
There was a problem hiding this comment.
This should have x-version-added: '2.19' as well
Signed-off-by: hye-on <[email protected]>
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Xtansia
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
timefield to theGetStatsschema in_common.yml.Issues Resolved
Related to opensearch-project/OpenSearch#16894
Related PR
opensearch-project/OpenSearch#17009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.