Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query insights dashboard 2.19 #5233

Merged

Conversation

derek-ho
Copy link
Contributor

@derek-ho derek-ho commented Jan 13, 2025

Description

Adds query insights dashboards plugin to 2.19 release, adds the backend and frontend plugin to 3.0.0 manifest.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
@ansjcy
Copy link
Member

ansjcy commented Jan 13, 2025

Thanks @rishabh6788 ! We have just cut the 2.x branch for query insights dashboards: https://github.com/opensearch-project/query-insights-dashboards/commits/2.x/

@peterzhuamazon
Copy link
Member

Has an onboard ticket being cut in this repo?

@ansjcy
Copy link
Member

ansjcy commented Jan 14, 2025

@peterzhuamazon Just created the onboarding ticket for query insights dashboards plugin: #5235

@gaiksaya
Copy link
Member

Thanks @rishabh6788 ! We have just cut the 2.x branch for query insights dashboards: https://github.com/opensearch-project/query-insights-dashboards/commits/2.x/

@ansjcy Can you please remove the to-do comment from the yaml?
Thanks!

@peterzhuamazon
Copy link
Member

Note added to opensearch plugins meta:

Signed-off-by: Derek Ho <[email protected]>
@ansjcy
Copy link
Member

ansjcy commented Jan 17, 2025

Hey @rishabh6788 @gaiksaya, thanks for the review! Derek just updated the PR to remove the todo. Let me know if you think it's good to merge - I saw a build failure though. But looks like a non-related one

@gaiksaya gaiksaya merged commit 6c0ffa1 into opensearch-project:main Jan 17, 2025
13 of 14 checks passed
@gaiksaya
Copy link
Member

Hi @derek-ho @ansjcy

Can you also please add the plugins to the test manifests?
Example 2.19.0: https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.19.0/opensearch-dashboards-2.19.0-test.yml and similarly to 3.0.0 test manifest as well?
Thanks!

@dzane17
Copy link
Contributor

dzane17 commented Jan 28, 2025

Hi @derek-ho @ansjcy

Can you also please add the plugins to the test manifests? Example 2.19.0: https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.19.0/opensearch-dashboards-2.19.0-test.yml and similarly to 3.0.0 test manifest as well? Thanks!

Done in #5273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants