[2.13] Switch to Private Tenant for Gantt Charts Tests

[sejli]

Description

Duplicate of #1194 to attempt on 2.13 since OS is more stable.
Since #1187 was merged in while the failures were unresolved, opening this one to fix failures. Setting to draft initially so it doesn't get merged before finished again. Following #1033 example of setting tenants

Needs backport 2.x and backport main labels. Must go in after #1190 and #1191

Issues Resolved

#354

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[sejli]

Failed run here

gantt_ui.spec.js.mp4

[Hailong-am]

Failed run here

gantt_ui.spec.js.mp4

I think the issue is here
cy.contains(GANTT_VIS_NAME).click({ force: true }); the page have two places have GANTT_VIS_NAME, one is the search bar, another is the table list. we need specify the exactly the table row and click.

recommend change to

cy.get('[data-test-subj="itemsInMemTable"]').contains(GANTT_VIS_NAME).click({
    force: true,
  });

[sejli]

Failed run here
gantt_ui.spec.js.mp4

I think the issue is here cy.contains(GANTT_VIS_NAME).click({ force: true }); the page have two places have GANTT_VIS_NAME, one is the search bar, another is the table list. we need specify the exactly the table row and click.

recommend change to

cy.get('[data-test-subj="itemsInMemTable"]').contains(GANTT_VIS_NAME).click({
    force: true,
  });

Nice catch, updated it in my latest commit. Both versions work on my local, might be some difference when running it in GitHub workflows.

[sejli]

Hmm, looks like it failed again. In the video, it does look like it's being clicked on. Not sure why it fails here but on my local its fine.

gantt_ui.spec.js.mp4

[Hailong-am]

Hmm, looks like it failed again. In the video, it does look like it's being clicked on. Not sure why it fails here but on my local its fine.

gantt_ui.spec.js.mp4

could you try to add some delay after search and before click ?

[Hailong-am]

Hmm, looks like it failed again. In the video, it does look like it's being clicked on. Not sure why it fails here but on my local its fine.
gantt_ui.spec.js.mp4

could you try to add some delay after search and before click ?

I have tried to add a delay for 2s, The CI passed https://github.com/Hailong-am/opensearch-dashboards-functional-test/actions/runs/8476894095/job/23227047701?pr=2

https://github.com/Hailong-am/opensearch-dashboards-functional-test/pull/2/files

[sejli]

I have tried to add a delay for 2s, The CI passed

Is it okay to add a cy.wait() here? I was under the impression that cy.wait() goes against testing best practices, and that we should avoid hardcoded waits as much as possible.

[Hailong-am]

Is it okay to add a cy.wait() here? I was under the impression that cy.wait() goes against testing best practices, and that we should avoid hardcoded waits as much as possible.

I think it's ok to use it, there have lots of cy.wait in our test.
For waiting for API to response, we recommend to use cy.intercept().as() combine with cy.wait().
But for page rendering, i think it's ok to use it.

[sejli]

Latest run failed on object not being saved. Looks like an error with saved objects

gantt_ui.spec.js.mp4

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1195-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e3105d6a678dfe382b165263157d1226348e7734
# Push it to GitHub
git push --set-upstream origin backport/backport-1195-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1195-to-2.x.