Update gantt chart tenant #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Apr 23, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
Not sure, but some plugins already have this. Gantt-charts needs this cause it's using saved-objects and index-patterns. |
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
Hi @SuZhou-Joe @ruanyl, Can you please review this PR and help backport it to main branch? |
|
@ps48 Actually the standard flow should be that
Please try to follow the best practice next time. :D |
SuZhou-Joe
approved these changes
Apr 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* update gantt chart tenant Signed-off-by: Shenoy Pratik <[email protected]> * fix add index pattern request Signed-off-by: Shenoy Pratik <[email protected]> * make default tenant global Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a60fa70)
CCongWang
pushed a commit
that referenced
this pull request
Apr 24, 2024
* update gantt chart tenant Signed-off-by: Shenoy Pratik <[email protected]> * fix add index pattern request Signed-off-by: Shenoy Pratik <[email protected]> * make default tenant global Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a60fa70) Co-authored-by: Shenoy Pratik <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…ct#1227) * update gantt chart tenant Signed-off-by: Shenoy Pratik <[email protected]> * fix add index pattern request Signed-off-by: Shenoy Pratik <[email protected]> * make default tenant global Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a60fa70) Co-authored-by: Shenoy Pratik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds global tenant to gantt-charts
Issues Resolved
opensearch-project/dashboards-visualizations#357
opensearch-project/dashboards-visualizations#362
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.