Reindex GitHub Events into maintainer inactivity data #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
============================================
+ Coverage 86.58% 86.83% +0.24%
- Complexity 271 315 +44
============================================
Files 64 69 +5
Lines 1491 1762 +271
Branches 58 78 +20
============================================
+ Hits 1291 1530 +239
- Misses 177 195 +18
- Partials 23 37 +14 ☔ View full report in Codecov by Sentry. |
bshien
force-pushed
the
maintainer-engagement-2
branch
3 times, most recently
from
d6aeb02 to
90db87d
Compare
bshien
force-pushed
the
maintainer-engagement-2
branch
6 times, most recently
from
a6d5c23 to
c1183b8
Compare
bshien
force-pushed
the
maintainer-engagement-2
branch
3 times, most recently
from
59ff2e8 to
19db2c1
Compare
| @@ -69,6 +69,7 @@ export class OpenSearchMetricsMonitoringStack extends Stack { | |||
| private snsMonitorStepFunctionExecutionsFailed(): void { | |||
| const stepFunctionSnsAlarms = [ | |||
| { alertName: 'StepFunction_execution_errors_MetricsWorkflow', stateMachineName: this.props.workflowComponent.opensearchMetricsWorkflowStateMachineName }, | |||
| { alertName: 'StepFunction_execution_errors_MaintainerInactivityWorkflow', stateMachineName: this.props.workflowComponent.opensearchMaintainerInactivityWorkflowStateMachineName }, | |||
There was a problem hiding this comment.
NIT: moving forward should this infrastructure/lib/stacks/monitoringDashboard.ts have inputs on the workflows to monitor?
bshien
force-pushed
the
maintainer-engagement-2
branch
3 times, most recently
from
33ce872 to
3e84f99
Compare
prudhvigodithi
approved these changes
Nov 1, 2024
bshien
force-pushed
the
maintainer-engagement-2
branch
from
3e84f99 to
526989d
Compare
Signed-off-by: Brandon Shien <[email protected]>
bshien
force-pushed
the
maintainer-engagement-2
branch
from
526989d to
d2ded46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reindexed GitHub Events stored in the metrics cluster into maintainer inactivity data for further display.
Issues Resolved
Part of #57
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.