-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jenkins] Add Solutions CFN Create VPC Test #1159
Conversation
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=========================================
Coverage 80.76% 80.76%
Complexity 2948 2948
=========================================
Files 400 400
Lines 15104 15104
Branches 1021 1021
=========================================
Hits 12199 12199
Misses 2288 2288
Partials 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Tanner Lewis <[email protected]>
Signed-off-by: Tanner Lewis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like that we can have some tests for this code, amazing! However, I'm a little concerned about building up shell script when we could lean on higher level languages, what do you think?
vars/solutionsCFNTest.groovy
Outdated
sh "sudo npm install" | ||
withCredentials([string(credentialsId: 'migrations-test-account-id', variable: 'MIGRATIONS_TEST_ACCOUNT_ID')]) { | ||
withAWS(role: 'JenkinsDeploymentRole', roleAccount: "${MIGRATIONS_TEST_ACCOUNT_ID}", region: "us-east-1", duration: 3600, roleSessionName: 'jenkins-session') { | ||
sh "sudo --preserve-env cdk deploy 'Migration-Assistant-Infra-Create-VPC' --parameters Stage=${stage} --require-approval never --concurrency 3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use npm deploy
to reduce extra parameters like --require-approval
and CDK doesn't need to be installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only saves me not having to provide the --require-approval
flag I believe and CDK CLI will already be on the box. My preference is to keep the same, but open if others want to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really prefer we didn't have to run npm install -g cdk
as part of the env setup, by using npm run it ensures everything is correctly version locked. 🧂
Signed-off-by: Tanner Lewis <[email protected]>
Create JIRA to handle this: https://opensearch.atlassian.net/browse/MIGRATIONS-2231 |
Signed-off-by: Tanner Lewis <[email protected]>
Description
This change introduces a new Jenkins pipeline that synthesizes the Solutions Create VPC CFN template from this repository and deploys it to the test account. It will then perform the
initBootstrap
and ensure it exits properly as well as verifies that CLI tools such as cdk, docker, java, and python are now available on the box.Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-2228
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Jenkins AWS testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.