Use intermediate env var instead of interpolating directly in inline shell scripts #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shell scripts Signed-off-by: Thomas Farr <[email protected]>
Xtansia
requested review from
anirudha,
dblock,
joshuali925,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
dblock
approved these changes
Aug 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 18, 2024
…shell scripts (#756) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 80287ba)
Xtansia
added a commit
that referenced
this pull request
Aug 18, 2024
…shell scripts (#756) (#758) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 80287ba) Co-authored-by: Thomas Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow best practices for interpolating in inline scripts in GitHub Actions by using intermediate env vars.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.