Build: Cache Prometheus binary #3261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
andy-k-improving
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
acarbonetto
reviewed
Jan 23, 2025
YANG-DB
previously approved these changes
Jan 28, 2025
|
Thx both, I will update this to cache the last version only. |
Signed-off-by: Andy Kwok <[email protected]>
andy-k-improving
dismissed stale reviews from YANG-DB and penghuo
via
e929ac5
|
@YANG-DB @acarbonetto @penghuo I have updated the code to only re-use Prometheus binary when it matches the version. |
7 tasks
acarbonetto
reviewed
Jan 29, 2025
| @@ -306,7 +311,6 @@ task startPrometheus(type: SpawnProcessTask) { | |||
| task stopPrometheus(type: KillProcessTask) { | |||
| doLast { | |||
| file("$projectDir/bin/prometheus").deleteDir() | |||
| file("$projectDir/bin/prometheus.tar.gz").delete() | |||
There was a problem hiding this comment.
we can delete the tar.gz if it exists:
"prometheus-${prometheus_binary_version}.tar.gz"
There was a problem hiding this comment.
Hum, I'm thinking this differently, as if we keep this delete call with prometheus-versions.gz.
The module wouldn't be able to achieve the cache behaviour, because prometheus-versions.gz will always be absent during the next run of integ-test.startPrometheus( ).
Signed-off-by: Andy Kwok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the current design of Gradle test workflow, Gradle task
startPrometheusis designed to execute upon every integration test and docTest.However the current implementation of
startPrometheusandstopPrometheuswill force and trigger the re-download ofPrometheusbinary, no matter that is a first run or subsequent run. (~100 Mb)This result in waste of bandwidth and reduce on developer productivity, as integration test will be executed frequently during the typical development process.
Hence this is a PR to introduce FileExistCheck to only download Prometheus binary when it's absent.
Test plan:
integTestand make surePrometheus File Already Existsprinted on console and no additional files being downloaded on subsequent IT test execution.Related Issues
Resolves #3257
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.