Add artcommon to install #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @locriandev |
MartinPl0
force-pushed
the
add-artcommon
branch
3 times, most recently
from
9eafd98 to
3ac74f5
Compare
ashwindasr
commented
Nov 16, 2023
ashwindasr
commented
Nov 16, 2023
MartinPl0
force-pushed
the
add-artcommon
branch
from
3ac74f5 to
d850707
Compare
openshift-merge-robot
added
the
needs-rebase
MartinPl0
force-pushed
the
add-artcommon
branch
2 times, most recently
from
8ce57db to
724d75b
Compare
openshift-merge-robot
removed
the
needs-rebase
MartinPl0
force-pushed
the
add-artcommon
branch
2 times, most recently
from
343c94e to
0a87b3d
Compare
MartinPl0
force-pushed
the
add-artcommon
branch
from
0a87b3d to
695d42e
Compare
ashwindasr
commented
Nov 20, 2023
its already being installed with doozer, and was causing an issue here
|
@MartinPl0 take a look at 7b4e9c4 when you get a chance. Things to note:
|
|
Tested the builds in my hackspace, so I think it should work. Merging |
ashwindasr
commented
Nov 21, 2023
| # use same non-root user from the initial install | ||
| ARG USERNAME=dev | ||
| # On Linux, replace with your actual UID, GID if not the default 1000 | ||
| ARG USER_UID=1000 | ||
| ARG USER_GID=$USER_UID | ||
|
|
||
| WORKDIR /workspaces/art-bot | ||
|
|
||
| RUN git config --global --add safe.directory /workspaces/art-bot/art-tools |
There was a problem hiding this comment.
This can be removed if we use USER 0, need to check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding artcommon to Dockerfile install