[ART-8304] Clone art-tools into working directory and clean up post-install #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwindasr
requested changes
Nov 28, 2023
|
Also can consider removing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit changes the Dockerfiles to clone art-tools into the current working directory instead of a fixed path. It also ensures that the art-tools directory is removed after the installation process to keep the Docker image clean. This approach aligns with best practices for container filesystem organization and avoids potential issues with OpenShift's random user ID assignment.
MartinPl0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the Dockerfiles to clone art-tools into the current working directory instead of a fixed path. It also ensures that the art-tools directory is removed after the installation process to keep the Docker image clean. This approach aligns with best practices for container filesystem organization and avoids potential issues with OpenShift's random user ID assignment.