Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly url #177

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix nightly url #177

merged 3 commits into from
Apr 9, 2024

Conversation

Ximinhan
Copy link
Contributor

@Ximinhan Ximinhan commented Apr 8, 2024

fix nightly pullspec url prefix

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ximinhan. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

artbotlib/brew_list.py Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@Ximinhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 5389445 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -35,6 +35,10 @@

PROW_BASE_URL = 'https://prow.ci.openshift.org'

NIGHTLY_REGISTRY = 'registry.ci.openshift.org/ocp/release'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use registry.ci.openshift.org instead, which is referenced in many other places, eg:

  • pyartcd/constant.py:13
  • doozerlib/cli/images_streams.py:596
    and a few moew

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is art-bot repo

@Ximinhan Ximinhan merged commit 13ecc17 into openshift-eng:master Apr 9, 2024
0 of 3 checks passed
@Ximinhan Ximinhan deleted the fix-url branch April 9, 2024 02:54
@Ximinhan Ximinhan restored the fix-url branch April 9, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants