Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix art-bot what kernel is in rhcos cmd #181

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Apr 24, 2024

When Release Controller cannot load changelog for a nightly, we cannot fetch rhcos build id.
So instead of fetching it via RC api, fetch it from release image.

Test:

./art_bot_dev.py
Enter your command: What kernel is used in 4.16.0-0.nightly-2024-04-24-091844

build_info, pullspec, _ = await buildinfo.get_image_info(
self.so, 'machine-os-content', self.release_img)
labels = build_info['config']['config']['Labels']
if 'com.coreos.rpm.kernel-rt-core' in labels:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These no longer exist

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@thegreyd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 98d0dc4 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vfreex
Copy link
Contributor

vfreex commented Apr 25, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f1f4460 into openshift-eng:master Apr 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants