Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] IntegrationSource CRD to OCP #956

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 6, 2024

This is work in progress, for release 1.36

DO NOT MERGE

@openshift-ci openshift-ci bot requested review from aliok and creydr November 6, 2024 06:49
Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 6, 2024
@matzew
Copy link
Member Author

matzew commented Nov 11, 2024

/hold

@matzew matzew force-pushed the integrationsource_1.16_ocp branch from 68b5a79 to b00e940 Compare January 31, 2025 08:12
@matzew
Copy link
Member Author

matzew commented Jan 31, 2025

/retest

* Add initial raw API types and controller/reconciler. Levering internally the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved.
Tests/lifeccyle and some other improvements are still missing. but this works.

Signed-off-by: Matthias Wessendorf <[email protected]>

* adding reflection to make the mapping less verbose, and more flexible to extend...

Signed-off-by: Matthias Wessendorf <[email protected]>

* Add DDB Streams

Signed-off-by: Matthias Wessendorf <[email protected]>

* polish and add minimal tests

Signed-off-by: Matthias Wessendorf <[email protected]>

* Update pkg/apis/sources/v1alpha1/integration_lifecycle.go

Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Update pkg/apis/sources/v1alpha1/integration_lifecycle.go

Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Fix compiler warnings

Signed-off-by: Matthias Wessendorf <[email protected]>

* use other image coordinates

Signed-off-by: Matthias Wessendorf <[email protected]>

* first test for source

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding initial rekt test

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding SSL support and test for IntegrationSource

Signed-off-by: Matthias Wessendorf <[email protected]>

* Formatting fixes

Signed-off-by: Matthias Wessendorf <[email protected]>

* Disable OIDC tests for now

Signed-off-by: Matthias Wessendorf <[email protected]>

* use knative nightly images

Signed-off-by: Matthias Wessendorf <[email protected]>

* Fixing linters

Signed-off-by: Matthias Wessendorf <[email protected]>

* addressing comments, Part1

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
@matzew matzew force-pushed the integrationsource_1.16_ocp branch from b00e940 to ae793a3 Compare February 12, 2025 16:19
Copy link

openshift-ci bot commented Feb 12, 2025

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-e2e-aws-416 68b5a79 link true /test 416-test-e2e-aws-416
ci/prow/416-test-conformance-aws-416 68b5a79 link true /test 416-test-conformance-aws-416
ci/prow/416-test-encryption-auth-e2e-aws-416 68b5a79 link true /test 416-test-encryption-auth-e2e-aws-416
ci/prow/416-test-reconciler-aws-416 68b5a79 link true /test 416-test-reconciler-aws-416
ci/prow/417-test-conformance ae793a3 link true /test 417-test-conformance
ci/prow/417-test-encryption-auth-e2e ae793a3 link true /test 417-test-encryption-auth-e2e
ci/prow/417-test-reconciler ae793a3 link true /test 417-test-reconciler
ci/prow/417-test-e2e ae793a3 link true /test 417-test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@matzew
Copy link
Member Author

matzew commented Feb 13, 2025

E0212 18:46:43.840542       1 reflector.go:150] knative.dev/pkg/controller/controller.go:726: Failed to watch *v1alpha1.IntegrationSource: failed to list *v1alpha1.IntegrationSource: integrationsources.sources.knative.dev is forbidden: User "system:serviceaccount:knative-eventing:eventing-controller" cannot list resource "integrationsources" in API group "sources.knative.dev" at the cluster scope

But I see the list in https://github.com/matzew/eventing/blob/integrationsource_1.16_ocp/config/core/roles/sources-controller-clusterroles.yaml#L69-L71

@matzew
Copy link
Member Author

matzew commented Feb 14, 2025

/close

this go in differently

@openshift-ci openshift-ci bot closed this Feb 14, 2025
Copy link

openshift-ci bot commented Feb 14, 2025

@matzew: Closed this PR.

In response to this:

/close

this go in differently

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant