Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Remove conversion webhook config in EventPolicy CRD #982

Conversation

creydr
Copy link
Member

@creydr creydr commented Dec 11, 2024

As we don't have multiple EventPolicy versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD.

Cherry-pick of https://github.com/knative/eventing/pull/8379/files

/cherry-pick release-v1.16

As we don't have multiple EP versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD
@creydr creydr requested a review from pierDipi December 11, 2024 08:59
@openshift-ci openshift-ci bot requested review from aliok and lberk December 11, 2024 08:59
Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-run make generate-release

@creydr creydr requested a review from pierDipi December 11, 2024 10:27
@pierDipi pierDipi merged commit d263a88 into openshift-knative:release-v1.15 Dec 11, 2024
32 of 59 checks passed
@openshift-cherrypick-robot

@creydr: new pull request created: #984

In response to this:

As we don't have multiple EventPolicy versions yet, we don't need the conversion webhook configuration in the EventPolicy CRD.

Cherry-pick of https://github.com/knative/eventing/pull/8379/files

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants