fix CWE-703

explicitly close the file and handle errors.

Close is considered unsafe to defer, because it might fail

pkg/profilecreator/profilecreator.go

@@ -106,6 +106,7 @@ func getMustGatherFullPaths(mustGatherPath string, suffix string) (string, error
 
 func getNode(mustGatherDirPath, nodeName string) (*v1.Node, error) {
 	var node v1.Node
+
 	nodePathSuffix := path.Join(ClusterScopedResources, CoreNodes, nodeName)
 	path, err := getMustGatherFullPaths(mustGatherDirPath, nodePathSuffix)
 	if err != nil {
@@ -116,12 +117,14 @@ func getNode(mustGatherDirPath, nodeName string) (*v1.Node, error) {
 	if err != nil {
 		return nil, fmt.Errorf("failed to open %q: %v", path, err)
 	}
-	defer src.Close()
 
 	dec := k8syaml.NewYAMLOrJSONDecoder(src, 1024)
 	if err := dec.Decode(&node); err != nil {
 		return nil, fmt.Errorf("failed to decode %q: %v", path, err)
 	}
+	if err := src.Close(); err != nil {
+		return nil, fmt.Errorf("error closing file %s: %s", src.Name(), err)
+	}
 	return &node, nil
 }
 
@@ -200,11 +203,13 @@ func GetMCP(mustGatherDirPath, mcpName string) (*machineconfigv1.MachineConfigPo
 	if err != nil {
 		return nil, fmt.Errorf("failed to open %q: %v", mcpPath, err)
 	}
-	defer src.Close()
 	dec := k8syaml.NewYAMLOrJSONDecoder(src, 1024)
 	if err := dec.Decode(&mcp); err != nil {
 		return nil, fmt.Errorf("failed to decode %q: %v", mcpPath, err)
 	}
+	if err := src.Close(); err != nil {
+		return nil, fmt.Errorf("error closing file %s: %s", src.Name(), err)
+	}
 	return &mcp, nil
 }