Skip to content

Commit

Permalink
add image registry doc
Browse files Browse the repository at this point in the history
Signed-off-by: myan <[email protected]>
  • Loading branch information
yanmxa committed May 28, 2024
1 parent 4fea814 commit 60fc16f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ environment:=${USER}
namespace ?= maestro-${USER}
agent_namespace ?= maestro-agent-${USER}

# a tool for managing containers and images, etc. You can set it as docker
container_tool ?= podman
# a tool for managing containers and images, etc. Podman or Docker
container_tool ?= $(shell command -v podman >/dev/null 2>&1 && echo podman || (command -v docker >/dev/null 2>&1 && echo docker))

# In the development environment we are pushing the image directly to the image
# registry inside the development cluster. That registry has a different name
Expand Down
8 changes: 2 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -321,13 +321,9 @@ Login Succeeded!

Deploy maestro:

Before deploying maestro to the Openshift cluster, we will first build image. By default, the container tool is `podman`, but you can override it to use `docker` when necessary.
```shell
$ export container_tool=docker
```

Then we will push the image to your OpenShift cluster default registry and then deploy it to the cluster. You need to follow [this document](https://docs.openshift.com/container-platform/4.13/registry/securing-exposing-registry.html) to expose a default registry manually and login into the registry with podman. You can also specific the image information with the environment variables `external_image_registry`, `image_repository` and `image_tag`
We will push the image to your OpenShift cluster default registry and then deploy it to the cluster. You need to follow [this document](https://docs.openshift.com/container-platform/4.13/registry/securing-exposing-registry.html) to expose a default registry manually and login into the registry with podman. You can also customize the image with the environment variables `external_image_registry`, `image_repository` and `image_tag`.

> Note: The meastro image pulled during deploying comes from the `internal_image_registry`, be sure to specify the correct value for the registry.
```shell
$ make deploy
Expand Down

0 comments on commit 60fc16f

Please sign in to comment.