Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename manifest to payload in database #110

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Jun 4, 2024

No description provided.

@gurnben
Copy link
Contributor

gurnben commented Jun 7, 2024

/retest

@clyang82 clyang82 merged commit 7bb3466 into openshift-online:main Jun 12, 2024
5 checks passed
@clyang82 clyang82 deleted the payload branch June 12, 2024 02:23
// Manifest holds the resource manifest in CloudEvent format (JSON representation).
Manifest datatypes.JSON `gorm:"type:json"`
// Payload is CloudEvent payload with CloudEvent format (JSON representation).
Payload datatypes.JSON `gorm:"type:json"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

I am seeing this

failed to create resource: maestro-9: Unable to create Resource: pq: column "payload" of relation "resources" does not exist

when I deploy the latest main against an existing deployment.
Ideally, this should've been a new migration file so that the column rename is applied. Renaming a column here, won't work for existing deployments as the migration id has already been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants