ensure maestro instance ready after adding to hash ring. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
force-pushed
the
br_health_check
branch
8 times, most recently
from
852d8b0 to
0a5db1c
Compare
|
LGTM |
morvencao
force-pushed
the
br_health_check
branch
from
d942ae2 to
1971a80
Compare
Signed-off-by: morvencao <[email protected]>
Signed-off-by: morvencao <[email protected]>
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_health_check
branch
from
1971a80 to
59981a3
Compare
|
/assign @clyang82 |
|
/ok-to-test |
machi1990
reviewed
Dec 17, 2024
Comment on lines
11
to
17
| func addServerInstances() *gormigrate.Migration { | ||
| type ServerInstance struct { | ||
| Model | ||
| LastHeartbeat time.Time | ||
| Ready bool `gorm:"default:false"` | ||
| } | ||
|
|
There was a problem hiding this comment.
This should have been a new migration and not an edit of an existing migration.
@morvencao @skeeey @clyang82 because of this, the migration doesn't get applied to existing deployments as it was already applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://issues.redhat.com/browse/ACM-16392