fix(migration): add last_heartbet and ready as column of server_instances tables in a separate migration

[machi1990]

fix(migration): add last_heartbet and ready as column of server_instances tables in a separate migration

Addresses https://github.com/openshift-online/maestro/pull/229/files#r1888513628 as the issue is causing existing deployment to fail with errors like

2024-12-17T13:19:34.107Z	ERROR	server/healthcheck_server.go:115	Unable to create maestro instance: ERROR: column "last_heartbeat" of relation "server_instances" does not exist (SQLSTATE 42703)
github.com/openshift-online/maestro/cmd/maestro/server.(*HealthCheckServer).pulse

or

2024-12-17T13:19:54.339Z	ERROR	server/healthcheck_server.go:184	Unable to mark inactive maestro instances ([maestro-maestro-689869f6dd-5jsbs maestro-maestro-689869f6dd-6tgxq]): ERROR: column "ready" of relation "server_instances" does not exist (SQLSTATE 42703)
github.com/openshift-online/maestro/cmd/maestro/server.(*HealthCheckServer).checkInstances

[clyang82]

Here is the integration error:

=== RUN   TestConsumerGet
I1217 13:48:36.117311   23046 api_server.go:151] Serving without TLS at 8000
{"level":"info","ts":1734443316.1173534,"logger":"fallback","caller":"[email protected]/protocol.go:133","msg":"subscribing to topics: [{sources/maestro/consumers/+/agentevents 1 0 false false}]"}
E1217 13:48:36.120090   23046 healthcheck_server.go:147] Unable to get all maestro instances: pq: relation "server_instances" does not exist
E1217 13:48:36.120119   23046 logger.go:129]   Unable to get all maestro instances: pq: relation "server_instances" does not exist 
E1217 13:48:36.120239   23046 healthcheck_server.go:119] Unable to get maestro instance: pq: relation "server_instances" does not exist
E1217 13:48:36.120451   23046 panic.go:261] "Observed a panic" panic="runtime error: invalid memory address or nil pointer dereference" panicGoValue="\"invalid memory address or nil pointer dereference\"" stacktrace=<
	goroutine 50 [running]:
	k8s.io/apimachinery/pkg/util/runtime.logPanic({0x2e9b390, 0x47b3de0}, {0x2613e60, 0x46d95f0})
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:107 +0xbc
	k8s.io/apimachinery/pkg/util/runtime.handleCrash({0x2e9b390, 0x47b3de0}, {0x2613e60, 0x46d95f0}, {0x47b3de0, 0x0, 0x100000002458e80?})
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:82 +0x5e
	k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0x24?})
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:59 +0x108
	panic({0x2613e60?, 0x46d95f0?})
		/usr/local/go/src/runtime/panic.go:770 +0x132
	github.com/openshift-online/maestro/cmd/maestro/server.(*HealthCheckServer).pulse(0xc0007aafc0, {0x2e9b438, 0xc0007b2230})
		/maestro/cmd/maestro/server/healthcheck_server.go:121 +0x6a0
	k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1()
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/backoff.go:259 +0x1f
	k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0x30?)
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/backoff.go:226 +0x33
	k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc000925f70, {0x2e77220, 0xc000558000}, 0x1, 0xc0001142a0)
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/backoff.go:227 +0xaf
	k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc000469770, 0x3b9aca00, 0x0, 0x1, 0xc0001142a0)
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/backoff.go:204 +0x7f
	k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext({0x2e9b438, 0xc0007b2230}, 0xc0002ca010, 0x3b9aca00, 0x0, 0x1)
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/backoff.go:259 +0x93
	k8s.io/apimachinery/pkg/util/wait.UntilWithContext(...)
		/root/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/backoff.go:170
	created by github.com/openshift-online/maestro/cmd/maestro/server.(*HealthCheckServer).Start in goroutine 122
		/maestro/cmd/maestro/server/healthcheck_server.go:60 +0x13e
 >
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x60 pc=0x22aad40]

[morvencao]

do we need Model here？

[machi1990]

No we don't need the Model.

[clyang82]

/retest

[clyang82]

/retest

[clyang82]

LGTM