Support Kafka #80
Merged
Support Kafka #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeeey
reviewed
Apr 22, 2024
| return err | ||
| } | ||
| cloudEventsSourceOptions = mqtt.NewSourceOptions(mqttOptions, e.Config.MessageBroker.ClientID, e.Config.MessageBroker.SourceID) | ||
| } else if e.Config.MessageBroker.MessageBrokerType == work.ConfigTypeKafka { |
There was a problem hiding this comment.
instead of if/else , can this be an injectable implementation of an interface?
There was a problem hiding this comment.
Hi @markturansky I added a TODO to create a CloudEventsSourceOptionsBuilder to build the CloudEventsSourceOptions in sdk repo. Thanks.
clyang82
force-pushed
the
kafka
branch
2 times, most recently
from
b79cf19 to
0c87419
Compare
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
qiujian16
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support kafka as a new message broker for maestro.