Support UpdateStrategy and DeleteOption #99
Conversation
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
clyang82
changed the title
| @@ -70,7 +70,7 @@ func (h resourceHandler) Patch(w http.ResponseWriter, r *http.Request) { | |||
| func() (interface{}, *errors.ServiceError) { | |||
| ctx := r.Context() | |||
| id := mux.Vars(r)["id"] | |||
| manifest, err := presenters.ConvertResourceManifest(patch.Manifest) | |||
| manifest, err := presenters.ConvertResourceManifest(patch.Manifest, patch.DeleteOption, patch.UpdateStrategy) | |||
There was a problem hiding this comment.
I think we should support update these options.
There was a problem hiding this comment.
Do you mean PATCH these options? if so, it was covered. I am working on adding test cases for that.
| @@ -406,6 +472,12 @@ func (o Resource) ToMap() (map[string]interface{}, error) { | |||
| if !IsNil(o.Manifest) { | |||
| toSerialize["manifest"] = o.Manifest | |||
| } | |||
| if !IsNil(o.DeleteOption) { | |||
| toSerialize["delete_option"] = o.DeleteOption | |||
There was a problem hiding this comment.
delete_option or deleteOption?
There was a problem hiding this comment.
in restful api, it seems we should use delete_option. for example: consumer_name create_at etc https://github.com/openshift-online/maestro?tab=readme-ov-file#get-your-resource
| PropagationPolicy: workv1.DeletePropagationPolicyTypeForeground, | ||
| }, | ||
| Manifest: unstructured.Unstructured{Object: manifest}, | ||
| DeleteOption: delOption, |
There was a problem hiding this comment.
@skeeey would you confirm deleteOption here works in agent side?
There was a problem hiding this comment.
what kinds of cases are you concerned about?
we already have some test in our integration test https://github.com/open-cluster-management-io/ocm/blob/main/test/integration/cloudevents/deleteoption_test.go
fixed: #69
Introduce to configure the
delete_optionandupdate_strategywhen creating or patching resource.delete_option defines the option to delete the resource. It is optional when creating a resource. The propagationPolicy of
delete_optioncan be:Foregroundrepresents that the resource should be fourground deleted. This is a default value.Orphanrepresents that the resource is orphaned when deleting the resource.update_strategy defines the strategy to update the resource. It is optional when creating a resource. The type of
update_strategycan be:ServerSideApplymeans to update resource using server side apply with work-controller as the field manager. This is a default value.Updatemeans to update resource by an update call.CreateOnlymeans do not update resource based on current manifest.ReadOnlymeans only check the existence of the resource based on the resource's metadata.