Skip to content

Commit

Permalink
Fix publish release action
Browse files Browse the repository at this point in the history
The action that publishes releases was uploading artifacts using the
`--data` option of the `curl` tool. That results in processing them as
ASCII and limits the size to approximately 4 MiB. The end result is that
the uploaded binaries don't work. This patch fixes that using the
`--data-binary` option instead.

Signed-off-by: Juan Hernandez <[email protected]>
  • Loading branch information
jhernand committed Sep 24, 2021
1 parent f2172d0 commit 416953f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/publish-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
--header "Content-Type: application/json" \
--header "Accept: application/json" \
--url "https://api.github.com/repos/${{ github.repository }}/releases" \
--data @request.json \
--data-binary @request.json \
--output response.json \
--fail
Expand All @@ -103,7 +103,7 @@ jobs:
--header "Content-Type: application/octect-stream" \
--header "Accept: application/json" \
--url "https://uploads.github.com/repos/${{ github.repository }}/releases/${id}/assets?name=${file}" \
--data "@assets/${file}" \
--data-binary "@assets/${file}" \
--output response.json \
--fail
done

0 comments on commit 416953f

Please sign in to comment.