Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARO-15553 | Add inflight checks endpoints to the ARO HCP service #1023

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

oriAdler
Copy link
Contributor

@oriAdler oriAdler commented Mar 3, 2025

No description provided.

@@ -38,4 +38,9 @@ resource Cluster {
locator Status {
target ClusterStatus
}

// Reference to the resource that manages the collection of inflight checks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spacing here is misaligned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@nimrodshn
Copy link
Contributor

LGTM 💯

@ahitacat
Copy link
Contributor

ahitacat commented Mar 4, 2025

LGTM 🦭

@oriAdler
Copy link
Contributor Author

oriAdler commented Mar 5, 2025

@nimrodshn I've addressed the comment, can you rePTAL?

@nimrodshn
Copy link
Contributor

LGTM 💯

@oriAdler oriAdler merged commit e88f28a into openshift-online:main Mar 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants