OCM-6407 | edit option sends an empty payload

[ahitacat]

EDIT

This commit adds a parameter when creating the command that check for a minimum amount of arguments. The
command will fail if no parameters are used.

[tzvatot]

I suggest to use cmd.Flags().NFlag() and if it's < 1 then print an INFO message that no change is done.

[ahitacat]

I see there is also used in this cli tool the builtin args validator.

var Cmd = &cobra.Command{
	...
	Args: cobra.MinimumNArgs(2),
}

If I remove the clusterNeedsUpdate bool, I see a possible problem when the --enable-delete-protection parameter is added. As that parameter doesn't require to update the cluster.

[tzvatot]

I see there is also used in this cli tool the builtin args validator.

var Cmd = &cobra.Command{
	...
	Args: cobra.MinimumNArgs(2),
}

If I remove the clusterNeedsUpdate bool, I see a possible problem when the --enable-delete-protection parameter is added. As that parameter doesn't require to update the cluster.

Why not? it requires a patch to the /delete_protection endpoint. It's not the cluster's endpoint, but it's still semantically updating the cluster.

[mnecas]

Agree with @ahitacat in case we will use the --enable-delete-protection without adding any check to [1] we will still send empty patch request to the /clusters/{id} endpoint and patch to update the delete-protection to /clusters/{id}/delete_protection. This could lead to unexpected behaviour as we would not update anything in the /clusters/{id} but still could fail on permission check.

[1]

ocm-cli/cmd/ocm/edit/cluster/cmd.go

Line 271 in 1095264

err = c.UpdateCluster(clusterCollection, cluster.ID(), clusterConfig)

[mnecas]

Ah did not know about the #603 should be good.
lgmt

[tzvatot]

LGTM