Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-5736 | feat: Make auth and device code flags visible #604

Merged
merged 2 commits into from
Mar 25, 2024
Merged

OCM-5736 | feat: Make auth and device code flags visible #604

merged 2 commits into from
Mar 25, 2024

Conversation

tirthct
Copy link
Contributor

@tirthct tirthct commented Mar 1, 2024

Changed

  • Make auth and device code flags visible

Tested

  • Flags should be visible in ocm login --help : tested

@tylercreller
Copy link
Member

tylercreller commented Mar 1, 2024 •
edited
Loading

LGTM

cristianoveiga
cristianoveiga approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@cristianoveiga cristianoveiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristianoveiga cristianoveiga merged commit 383d362 into openshift-online:main Mar 25, 2024
4 checks passed
@tirthct tirthct deleted the ocm-5736 branch March 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylercreller tylercreller tylercreller approved these changes

@cristianoveiga cristianoveiga cristianoveiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tirthct @tylercreller @cristianoveiga