Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding interactive mode for WifConfig creation #675

Merged
merged 1 commit into from
Oct 17, 2024
Merged

adding interactive mode for WifConfig creation #675

merged 1 commit into from
Oct 17, 2024

Conversation

renan-campos
Copy link
Collaborator

Tests:

[rcampos@rcampos-thinkpadt14sgen2i ocm-cli]$ ./ocm gcp create wif-config 
Error: flag 'name' is required
[rcampos@rcampos-thinkpadt14sgen2i ocm-cli]$ ./ocm gcp create wif-config --name rc-test
Error: Flag 'project' is required
[rcampos@rcampos-thinkpadt14sgen2i ocm-cli]$ ./ocm gcp create wif-config --name rc-test --project sda-ccs-1
2024/10/15 16:43:51 Creating workload identity configuration...

[rcampos@rcampos-thinkpadt14sgen2i ocm-cli]$ ./ocm gcp create wif-config --interactive
? WifConfig name rc-test
? Gcp Project ID sda-ccs-1
2024/10/15 16:44:15 Creating workload identity configuration...

@renan-campos renan-campos changed the title adding interactive move for WifConfig creation adding interactive mode for WifConfig creation Oct 16, 2024
@renan-campos renan-campos self-assigned this Oct 16, 2024
@renan-campos renan-campos requested a review from ckandag October 16, 2024 16:23
@ckandag ckandag merged commit f1d29bc into openshift-online:main Oct 17, 2024
4 checks passed
ckandag added a commit that referenced this pull request Oct 25, 2024
@ckandag
Release v1.0.2
021835c 
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
@ckandag ckandag mentioned this pull request Oct 25, 2024
Merged
renan-campos pushed a commit that referenced this pull request Oct 25, 2024
@ckandag
Release v1.0.2 (#689)
c2a39c6 
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobGray JakobGray JakobGray approved these changes

@ckandag ckandag ckandag approved these changes

Assignees

@renan-campos renan-campos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renan-campos @ckandag @JakobGray